Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/ssa: incorrect document in type Builtin struct #46972

Closed
satorunooshie opened this issue Jun 29, 2021 · 5 comments
Closed

x/tools/go/ssa: incorrect document in type Builtin struct #46972

satorunooshie opened this issue Jun 29, 2021 · 5 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@satorunooshie
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.16.5 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/perry/Library/Caches/go-build"
GOENV="/Users/perry/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/perry/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/perry/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16.5"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/b3/589l2twx2pvfl_fhcpwb2dp40000gn/T/go-build2376217183=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Read the source code at https://github.com/golang/tools/blob/master/go/ssa/ssa.go#L440

What did you expect to see?

// A Builtin represents a specific use of a built-in function, e.g. len.
//
// Builtins are immutable values.  Builtins do not have addresses.
// Builtins can only appear in CallCommon.Value.

What did you see instead?

// A Builtin represents a specific use of a built-in function, e.g. len.
//
// Builtins are immutable values.  Builtins do not have addresses.
// Builtins can only appear in CallCommon.Func.
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 29, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jun 29, 2021
@ianlancetaylor
Copy link
Contributor

Thanks. Note that it's not necessary to open an issue for a documentation issue if you are going to send a patch anyhow. It's fine to just send the patch. Thanks.

@satorunooshie
Copy link
Author

Okay! Thanks.🥳

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 30, 2021
@gopherbot
Copy link

Change https://golang.org/cl/331310 mentions this issue: go/ssa: incorrect document in type Builtin struct

@ZekeLu
Copy link
Contributor

ZekeLu commented May 11, 2022

golang/tools#327 has been merged and I think this issue can be closed. (the referenced issue in the Fixes line is Fixes #46972).

@timothy-king
Copy link
Contributor

Looks closed to me too.

@golang golang locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

6 participants