Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestCVE202133195 fails if /etc/resolv.conf specifies ndots larger than 3 #46955

Closed
shawndx opened this issue Jun 28, 2021 · 5 comments
Closed

net: TestCVE202133195 fails if /etc/resolv.conf specifies ndots larger than 3 #46955

shawndx opened this issue Jun 28, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@shawndx
Copy link
Contributor

shawndx commented Jun 28, 2021

What version of Go are you using (go version)?

$ go version

go version devel go1.17-c95464f0ea Sun Jun 27 05:06:30 2021 +0000 linux/amd64

Does this issue reproduce with the latest release?

Reproducible with go1.16.5

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="auto"
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"

What did you do?

In /etc/resolv.conf there is "options ndots:5", then ./make.bash failed with the following error.

--- FAIL: TestCVE202133195 (0.00s)
dnsclient_unix_test.go:1925: Resolver.LookupSRV returned unexpected error, got "lookup golang.org: SRV target is invalid", want "lookup golang.org: SRV header name is invalid"
dnsclient_unix_test.go:1929: LookupSRV returned unexpected error, got "lookup golang.org: SRV target is invalid", want "lookup golang.org: SRV header name is invalid"
FAIL
FAIL net 5.458s

What did you expect to see?

What did you see instead?
@gopherbot
Copy link

Change https://golang.org/cl/330842 mentions this issue: net: fix failure of TestCVE202133195

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 28, 2021
@dmitshur dmitshur added this to the Backlog milestone Jun 28, 2021
@dmitshur
Copy link
Contributor

CC @rolandshoemaker.

@shawndx
Copy link
Contributor Author

shawndx commented Jun 30, 2021

@gopherbot please backport to 1.16

@gopherbot gopherbot mentioned this issue Jun 30, 2021
Closed
@gopherbot
Copy link

Backport issue(s) opened: #46981 (for 1.16).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@shawndx
Copy link
Contributor Author

shawndx commented Jun 30, 2021 •
edited

@gopherbot please consider this for backport to 1.15, it's a test failure

@dmitshur dmitshur mentioned this issue Jun 30, 2021
Closed
@golang golang locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @shawndx