Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql/driver: TestTxStmtDeadlock very flaky on android-amd64-emu #46916

Closed
mdempsky opened this issue Jun 24, 2021 · 6 comments
Closed

database/sql/driver: TestTxStmtDeadlock very flaky on android-amd64-emu #46916

mdempsky opened this issue Jun 24, 2021 · 6 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.18

Comments

@mdempsky
Copy link
Member

This test has been failing a lot for me over the past 4 days on the dev.typeparams branch:

https://storage.googleapis.com/go-build-log/04734dd8/android-amd64-emu_91b417d9.log
https://storage.googleapis.com/go-build-log/2d5720ec/android-amd64-emu_3daa9f0e.log
https://storage.googleapis.com/go-build-log/4eda6e8b/android-amd64-emu_98d25c3d.log
https://storage.googleapis.com/go-build-log/638413de/android-amd64-emu_9ecd75ba.log
https://storage.googleapis.com/go-build-log/7f1c4853/android-amd64-emu_9b30e641.log
https://storage.googleapis.com/go-build-log/970e4e58/android-amd64-emu_0d432260.log
https://storage.googleapis.com/go-build-log/bd75df28/android-amd64-emu_e258f125.log
https://storage.googleapis.com/go-build-log/dcbc3557/android-amd64-emu_e7b625fe.log
https://storage.googleapis.com/go-build-log/f696ac32/android-amd64-emu_f04fc144.log

These failures account for the majority of my unsuccessful trybot runs recently.

/cc @bcmills @kardianos
@mdempsky mdempsky added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Jun 24, 2021
@mdempsky mdempsky added this to the Go1.18 milestone Jun 24, 2021
@cuonglm
Copy link
Member

cuonglm commented Jun 25, 2021

I can reproduce it locally on Macbook M1:

$ go test -race -count=100 -run=TestTxStmtDeadlock
--- FAIL: TestTxStmtDeadlock (0.00s)
    sql_test.go:2851: sql: transaction has already been committed or rolled back
--- FAIL: TestTxStmtDeadlock (0.00s)
    sql_test.go:154: Error closing fakeConn: fakedb: can't close; dangling statement(s)
    sql_test.go:172: error closing DB: fakedb: can't close; dangling statement(s)
FAIL
exit status 1
FAIL	database/sql	0.934s

The fix in b73cc4b seems make the cancel() call too early, moving the call after tx.Prepare will fix the problem.

@cuonglm
Copy link
Member

cuonglm commented Jun 25, 2021

@mdempsky oh, it's fixed in 44f9a35, seems we just need to merge master to dev.typeparams

@mdempsky
Copy link
Member Author

@cuonglm Oh nice, thanks for tracking that down. Do you want to send a merge CL? I'm available to review/approve.

@cuonglm
Copy link
Member

cuonglm commented Jun 25, 2021

@cuonglm Oh nice, thanks for tracking that down. Do you want to send a merge CL? I'm available to review/approve.

I'm on it, need to resolving conflicts in internal/buildcfg/exp.go

@bcmills
Copy link
Contributor

bcmills commented Jun 25, 2021

Duplicate of #46852

@bcmills bcmills marked this as a duplicate of #46852 Jun 25, 2021
@cuonglm
Copy link
Member

cuonglm commented Jun 28, 2021

@cuonglm Oh nice, thanks for tracking that down. Do you want to send a merge CL? I'm available to review/approve.

https://go-review.googlesource.com/c/go/+/330829 was merged, we can now close this issue.

@cuonglm cuonglm closed this as completed Jun 28, 2021
@golang golang locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@mdempsky @cuonglm @bcmills @gopherbot