-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: crashes in slicing array converted from slice #46907
Comments
This looks like a serious issue. In 1.16, this would report: This also reproduces on tip. |
I'm AFK for a while, but on my phone, looks like the type for the return value in ssagen/ssa.go:3177 is wrong. It is TINT, but should be n.Type(). Anyone else should feel free to send this as a CL, if this diagnosis seems right. |
Change https://golang.org/cl/330672 mentions this issue: |
Yay, I actually have the CL ready one hour ago, but still trying to figure it out why the wrong type is not problem in normal case. Also, sounds like we are not consistent in the type argument passing with |
Probably because SSA doesn't do any type checking to make sure types are consistent, and Also, the feature is new, so we probably don't have any code to exercise that |
@mdempsky Only people in the go-assignees group can be assigned issues: https://github.com/orgs/golang/teams, but Cuong is not part of that group. |
@ALTree Thanks. Do you know how we fix that? I clicked around briefly, and either I couldn't figure out how to add members or I don't have authority to. Cuong has been a Gerrit approver for a while now. |
He's a gerrit approver but Github Access and Gerrit Access are two separated things. He needs to be part of the Golang Github organization first, he's currently not (he's not in https://github.com/orgs/golang/people and his github label says "contributor", not "member"). He should open an issue as described here: https://github.com/golang/go/wiki/GithubAccess asking for Assignees and Editors roles (if he wishes to). |
What version of Go are you using (
go version
)?What did you do?
What did you expect to see?
Compiles okay.
What did you see instead?
Compiler crashes.
The text was updated successfully, but these errors were encountered: