You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As @bcmills points out in CL 330253, there is a bug in the package qualification logic of CL 313035. The nominal bug is the use of pkg rather than check.pkg on line 34 of errors.go, but I additionally noticed that our test coverage is not functioning as we expect: testdata error message extraction stops at the first ", so assertions in check tests that were checking that imports were qualified were not actually checking anything.
Opening this as a release blocker for tracking purposes. I'm fixing now.
The text was updated successfully, but these errors were encountered:
…alification logic
This is a partial port of https://golang.org/cl/330629, containing
only the actual bug fix and adjustements to another test file.
The respective test case has not been ported yet as it requires
some bigger adjustments.
For #46905
Change-Id: Ibd20658b8a31855da20cf56e24bcce9560656ca0
Reviewed-on: https://go-review.googlesource.com/c/go/+/336350
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
As @bcmills points out in CL 330253, there is a bug in the package qualification logic of CL 313035. The nominal bug is the use of
pkg
rather thancheck.pkg
on line 34 of errors.go, but I additionally noticed that our test coverage is not functioning as we expect: testdata error message extraction stops at the first"
, so assertions in check tests that were checking that imports were qualified were not actually checking anything.Opening this as a release blocker for tracking purposes. I'm fixing now.
The text was updated successfully, but these errors were encountered: