Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: unable to add a post submit builder for non-master branch #46864

Open
cagedmantis opened this issue Jun 21, 2021 · 2 comments
Open

x/build/cmd/coordinator: unable to add a post submit builder for non-master branch #46864

cagedmantis opened this issue Jun 21, 2021 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@cagedmantis
Copy link
Contributor

cagedmantis commented Jun 21, 2021 •
edited by dmitshur

While troubleshooting #46786 we discovered an edge-case where a post submit was not initiated even thought the configuration seemed correct. @dmitshur discovered that the coordinator will not bootstrap post submit builds for builders which are not configured to run for the go repository in the master branch.

@golang/release
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Jun 21, 2021
@cagedmantis cagedmantis added this to the Backlog milestone Jun 21, 2021
@dmitshur
Copy link
Contributor

The second bullet point in #30779 is related to this.

@gopherbot
Copy link

Change https://golang.org/cl/329929 mentions this issue: cmd/coordinator: enable post submit builder for linux-amd64-unified

gopherbot pushed a commit to golang/build that referenced this issue Jun 24, 2021
@cagedmantis
cmd/coordinator: enable post submit builder for linux-amd64-unified
7cb49dd 
This change enables post submit builder runs for linux-amd64-unified
on the dev.typeparams branch. When the coordinator bootstraps new
builders, it omits builders which are not for the go repository and
the master branch.

Fixes golang/go#46786
Updates golang/go#46864

Change-Id: I4c74df8f02674e0265b455eee92983f2e6c41229
Reviewed-on: https://go-review.googlesource.com/c/build/+/329929
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur dmitshur modified the milestones: Backlog, Unreleased Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot