Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: TestTxStmtDeadlock failures with "transaction has already been committed or rolled back" #46852

Closed
bcmills opened this issue Jun 21, 2021 · 2 comments
Closed

database/sql: TestTxStmtDeadlock failures with "transaction has already been committed or rolled back" #46852

bcmills opened this issue Jun 21, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 21, 2021 •
edited

2021-06-21T14:58:02-7a5e704/android-amd64-emu

-- FAIL: TestTxStmtDeadlock (0.00s)
    sql_test.go:2851: sql: transaction has already been committed or rolled back
FAIL
exitcode=1FAIL	database/sql	1.681s

2021-06-21T14:57:47-85a2e24/android-amd64-emu
2020-11-19T19:35:35-add4593/dragonfly-amd64-5_8
2020-11-18T06:29:09-a14e7bf/freebsd-arm-paulzhol

See previously #46783, #42259. (CC @kardianos)
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 21, 2021
@bcmills bcmills added this to the Backlog milestone Jun 21, 2021
@kardianos
Copy link
Contributor

kardianos commented Jun 21, 2021 •
edited

That's somewhat embarrassing, though the line numbers on these errors are accurate now. I interspersed other time.Sleeps throughout and I think it should not fail on slower systems now. It still addresses the original deadlock if code is reverted.

https://go-review.googlesource.com/c/go/+/329830

@gopherbot
Copy link

Change https://golang.org/cl/329830 mentions this issue: database/sql: fix deadlock test in prepare statement

@bcmills bcmills mentioned this issue Jun 25, 2021
Closed
@golang golang locked and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@kardianos @bcmills @gopherbot