Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: TestTxStmtDeadlock failures with "context deadline exceeded" #46783

Closed
bcmills opened this issue Jun 16, 2021 · 4 comments
Closed

database/sql: TestTxStmtDeadlock failures with "context deadline exceeded" #46783

bcmills opened this issue Jun 16, 2021 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.17

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 16, 2021

2021-06-15T20:59:42-d77f4c0/freebsd-arm64-dmgk

--- FAIL: TestTxStmtDeadlock (0.02s)
    sql_test.go:2845: context deadline exceeded
FAIL
FAIL	database/sql	0.743s

2021-04-14T21:50:26-cbf9caa/freebsd-arm64-dmgk
2021-03-08T20:41:06-a08adda/freebsd-arm64-dmgk
2020-11-19T19:35:35-add4593/dragonfly-amd64-5_8

--- FAIL: TestTxStmtDeadlock (0.02s)
    sql_test.go:2827: sql: transaction has already been committed or rolled back
FAIL
FAIL	database/sql	0.781s

2020-11-18T06:29:09-a14e7bf/freebsd-arm-paulzhol

See previously #42259. (CC @kardianos)
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 16, 2021
@bcmills bcmills added this to the Backlog milestone Jun 16, 2021
@gopherbot
Copy link

Change https://golang.org/cl/328649 mentions this issue: database/sql: do not rely on timeout for deadlock test

@kardianos
Copy link
Contributor

sql_test.go:2845: context deadline exceeded

This can be addressed with removing the context timeout. I tested locally the associated fix and it still triggered it. CL Sent.

sql_test.go:2827: sql: transaction has already been committed or rolled back

This one is odd, I'm not sure where this is getting triggered because the line numbers don't match up. Maybe same fix? Unsure.

@dmitshur dmitshur modified the milestones: Backlog, Go1.17 Jun 19, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Jun 21, 2021

Hmm, looks like the second failure mode still occurs. I'll retitle this issue for the failure mode that is fixed and file a new one for the other failure mode.

@bcmills bcmills changed the title database/sql: failures in TestTxStmtDeadlock database/sql: TestTxStmtDeadlock failures with "context deadline exceeded" Jun 21, 2021
@bcmills bcmills mentioned this issue Jun 21, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/329830 mentions this issue: database/sql: fix deadlock test in prepare statement

@golang golang locked and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
4 participants
@kardianos @dmitshur @bcmills @gopherbot