Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall: TestGroupCleanupUserNamespace test failure on Fedora [1.16 backport] #46769

Closed
gopherbot opened this issue Jun 15, 2021 · 3 comments
Closed

syscall: TestGroupCleanupUserNamespace test failure on Fedora [1.16 backport] #46769

gopherbot opened this issue Jun 15, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.16.6

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #46752 to be considered for backport to the next 1.16 minor release.

@gopherbot Please open backport issues

This test failure happens when running minor releases on some systems. The fix is tiny, so may as well backport to avoid unexpected test failures when people build those releases from source.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 15, 2021
@gopherbot gopherbot mentioned this issue Jun 15, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.6 milestone Jun 15, 2021
@dmitshur
Copy link
Contributor

Approved as this is a small test fix. This backport applies to both 1.16 (this issue) and 1.15 (#46768).

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. and removed CherryPickCandidate Used during the release process for point releases labels Jun 21, 2021
@dmitshur dmitshur mentioned this issue Jun 21, 2021
Closed
@gopherbot
Copy link
Author

Change https://golang.org/cl/329831 mentions this issue: [release-branch.go1.16] syscall: fix TestGroupCleanupUserNamespace test failure on Fedora

@gopherbot
Copy link
Author

Closed by merging fd129a6 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Jun 21, 2021
@rabajaj0509 @ianlancetaylor
[release-branch.go1.16] syscall: fix TestGroupCleanupUserNamespace te…
fd129a6 
…st failure on Fedora

For #46752
Fixes #46769

Change-Id: I2eaa9d15fac4e859e18191fcf1372e5be94899df
GitHub-Last-Rev: 8a2672d
GitHub-Pull-Request: #46753
Reviewed-on: https://go-review.googlesource.com/c/go/+/328109
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
(cherry picked from commit a752bc0)
Reviewed-on: https://go-review.googlesource.com/c/go/+/329831
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.16.6
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot