Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: *1 scaling on ARM64 no longer work at tip #46766

Closed
cherrymui opened this issue Jun 15, 2021 · 1 comment
Closed

cmd/asm: *1 scaling on ARM64 no longer work at tip #46766

cherrymui opened this issue Jun 15, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.17

Comments

@cherrymui
Copy link
Member

What version of Go are you using (go version)?

tip (7841cb1)

Does this issue reproduce with the latest release?

No.

What did you do?

On ARM64, instruction like MOVD (R1)(R2*1), R3 assembles correctly with Go 1.16, but errors out on tip (with arm64 doesn't support scaled register format), since CL https://go-review.googlesource.com/c/go/+/289589.

Arguably MOVD (R1)(R2), R3 is the preferred form. But the *1 form works before and assembles correctly. I think we want to keep supporting this form.

cc @erifan
@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 15, 2021
@cherrymui cherrymui added this to the Go1.17 milestone Jun 15, 2021
@gopherbot
Copy link

Change https://golang.org/cl/328229 mentions this issue: cmd/asm: restore supporting of *1 scaling on ARM64

@sumo-drosiek sumo-drosiek mentioned this issue Jun 16, 2021
Merged
@golang golang locked and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui