Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/openpgp/s2k: build failing on windows-arm64-aws due to build error in x/sys/windows #46761

Closed
bcmills opened this issue Jun 15, 2021 · 3 comments
Labels
arch-arm64 FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 15, 2021

https://build.golang.org/log/dab244f0493db12d84e8c14db1770e836811f2d8:

# golang.org/x/sys/windows
..\..\..\..\pkg\mod\golang.org\x\sys@v0.0.0-20201119102817-f84b799fce68\windows\types_windows.go:1597:24: undefined: JOBOBJECT_BASIC_LIMIT_INFORMATION
..\..\..\..\pkg\mod\golang.org\x\sys@v0.0.0-20201119102817-f84b799fce68\windows\zsyscall_windows.go:2911:38: undefined: WSAData
..\..\..\..\pkg\mod\golang.org\x\sys@v0.0.0-20201119102817-f84b799fce68\windows\zsyscall_windows.go:2987:51: undefined: Servent
..\..\..\..\pkg\mod\golang.org\x\sys@v0.0.0-20201119102817-f84b799fce68\windows\zsyscall_windows.go:3001:50: undefined: Servent
ok  	golang.org/x/crypto/openpgp/s2k	15.633s
@bcmills bcmills added OS-Windows NeedsFix The path to resolution is known, but the work has not been done. arch-arm64 labels Jun 15, 2021
@bcmills bcmills added this to the Go1.17 milestone Jun 15, 2021
@gopherbot
Copy link

Change https://golang.org/cl/328149 mentions this issue: all: upgrade x/sys to latest

@bcmills
Copy link
Contributor Author

bcmills commented Jun 15, 2021

AFAICT this is a release-blocker for Go 1.17 via #11811.

@TopperDEL
Copy link

Sorry to ask on this closed issue - I get the same errors above while trying to build for windows/arm64. Should this be resolved by now? Or is it still pending? I'm using the latest go1.17-release. I just don't understand how the issue belongs to #11811. Can someone clarify this?
Thank you!

btwiuse pushed a commit to btwiuse/k0s that referenced this issue Jul 13, 2022
@golang golang locked and limited conversation to collaborators Aug 23, 2022
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
Fixes golang/go#46761

Change-Id: I510532f98c66db1ca1a2288665c571e86d605770
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/328149
Trust: Bryan C. Mills <bcmills@google.com>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
Fixes golang/go#46761

Change-Id: I510532f98c66db1ca1a2288665c571e86d605770
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/328149
Trust: Bryan C. Mills <bcmills@google.com>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants