Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile: bind tests (bind and cmd/gobind) are broken #46744

Closed
hyangah opened this issue Jun 14, 2021 · 2 comments
Closed

x/mobile: bind tests (bind and cmd/gobind) are broken #46744

hyangah opened this issue Jun 14, 2021 · 2 comments
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Jun 14, 2021

https://storage.googleapis.com/go-build-log/fdab5be1/linux-amd64-androidemu_5f1949ec.log

ok  	golang.org/x/mobile/bind/seq	0.026s
--- FAIL: TestDocs (0.46s)
    --- FAIL: TestDocs/Modules (0.33s)
        gobind_test.go:173: gobind -lang java failed: exit status 1: // Code generated by gobind. DO NOT EDIT.
     ...
            "golang.org/x/mobile/bind" is not found; run go get golang.org/x/mobile/bind: [-: missing go.sum entry for module providing package golang.org/x/mobile/bind; to add:
            	go mod download golang.org/x/mobile]
        gobind_test.go:173: gobind -lang objc failed: exit status 1: // Objective-C API for talking to example.com/doctest Go package.
     ...     
            unable to import bind/objc: [-: missing go.sum entry for module providing package golang.org/x/mobile/bind/objc; to add:
            	go mod download golang.org/x/mobile]
FAIL
FAIL	golang.org/x/mobile/cmd/gobind	80.625s
--- FAIL: TestBindWithGoModules (19.43s)
    --- FAIL: TestBindWithGoModules/android (17.07s)
        --- FAIL: TestBindWithGoModules/android/Absolute_Path (10.88s)
            bind_test.go:319: gomobile bind failed: exit status 1
                /workdir/tmp/gomobile-test439913593/gomobile: go build -buildmode=c-shared -o=/workdir/tmp/gomobile-work-721723007/android/src/main/jniLibs/armeabi-v7a/libgojni.so ./gobind failed: exit status 1
                go: github.com/BurntSushi/xgb@v0.0.0-20160522181843-27f122750802: missing go.sum entry; to add it:
                	go mod download github.com/BurntSushi/xgb
                go: github.com/BurntSushi/xgb@v0.0.0-20160522181843-27f122750802: missing go.sum entry; to add it:
                	go mod download github.com/BurntSushi/xgb
                
        --- FAIL: TestBindWithGoModules/android/Relative_Path (6.18s)
            bind_test.go:319: gomobile bind failed: exit status 1
                /workdir/tmp/gomobile-test439913593/gomobile: go build -buildmode=c-shared -o=/workdir/tmp/gomobile-work-3749682380/android/src/main/jniLibs/armeabi-v7a/libgojni.so ./gobind failed: exit status 1
                go: github.com/BurntSushi/xgb@v0.0.0-20160522181843-27f122750802: missing go.sum entry; to add it:
                	go mod download github.com/BurntSushi/xgb
                go: github.com/BurntSushi/xgb@v0.0.0-20160522181843-27f122750802: missing go.sum entry; to add it:
                	go mod download github.com/BurntSushi/xgb
                

All about missing go.sum entries. I think this is related to gobind generates go.mod file based on the binding source, but doesn't generate go.sum file. I wonder if simply running go mod tidy before building can fix the issue.

cc @hajimehoshi

@hyangah hyangah added the mobile Android, iOS, and x/mobile label Jun 14, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jun 14, 2021
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 14, 2021
@bcmills
Copy link
Contributor

bcmills commented Jun 15, 2021

I thought @jayconrod fixed this in CL 323149. Is it still failing at head?

(That was #46418.)

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jun 15, 2021
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

4 participants