Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/go1.17: change from issue 25192 is not mentioned in the go1.17 release notes #46706

Closed
yansal opened this issue Jun 11, 2021 · 5 comments
Closed
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@yansal
Copy link
Contributor

yansal commented Jun 11, 2021

This program prints a different output with go1.16.5 and go1.17beta1

package main

import (
	"fmt"
	"net/url"
)

func main() {
	u1, _ := url.Parse("http://host/path?q1=v1&q2=v2")
	fmt.Println(u1.Query())
	u2, _ := url.Parse("http://host/path?q1=v1;q2=v2")
	fmt.Println(u2.Query())
}

See #25192 for the details.

There is no mention of this change in the go1.17 release notes (https://tip.golang.org/doc/go1.17), although it may break existing programs.

@bcmills bcmills added Documentation okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker NeedsFix The path to resolution is known, but the work has not been done. labels Jun 11, 2021
@bcmills bcmills added this to the Go1.17 milestone Jun 11, 2021
@bcmills
Copy link
Contributor

bcmills commented Jun 11, 2021

@golang/security, someone want to add a release note?

@bcmills bcmills changed the title change from issue 25192 is not mentioned in the go1.17 release notes net/url: change from issue 25192 is not mentioned in the go1.17 release notes Jun 11, 2021
@bcmills bcmills changed the title net/url: change from issue 25192 is not mentioned in the go1.17 release notes doc/go1.17: change from issue 25192 is not mentioned in the go1.17 release notes Jun 11, 2021
@FiloSottile
Copy link
Contributor

I have a draft almost ready, will mail it today.

@FiloSottile FiloSottile self-assigned this Jun 11, 2021
@gopherbot
Copy link

Change https://golang.org/cl/327810 mentions this issue: doc/go1.17: add security-related release notes

@dmitshur dmitshur removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Jun 16, 2021
@toothrot
Copy link
Contributor

@FiloSottile Anything else to do here or can this be closed?

@FiloSottile
Copy link
Contributor

All done!

@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Development

No branches or pull requests

6 participants