Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/mod_invalid_version fails on Windows #46691

Closed
bcmills opened this issue Jun 10, 2021 · 1 comment
Closed

cmd/go: TestScript/mod_invalid_version fails on Windows #46691

bcmills opened this issue Jun 10, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 10, 2021

go test proxy running at GOPROXY=http://127.0.0.1:60426/mod
--- FAIL: TestScript (0.01s)
    --- FAIL: TestScript/mod_invalid_version (0.23s)
        script_test.go:252:
            # Regression test for golang.org/issue/27173: if the user (or go.mod file)
            # requests a pseudo-version that does not match both the module path and commit
            # metadata, reject it with a helpful error message.
            #
            # TODO(bcmills): Replace the github.com/pierrec/lz4 examples with something
            # equivalent on vcs-test.golang.org.
            # An incomplete commit hash is not a valid semantic version,
            # but can appear in the main go.mod file anyway and should be resolved. (0.202s)
            > cp go.mod.orig go.mod
            > go mod edit -require golang.org/x/text@14c0d48ead0c
            > cd outside
            $WORK\gopath\src\outside
            > ! go list -m golang.org/x/text
            [stderr]
            go list -m: example.com@v0.0.0 (replaced by ./..): parsing ..\go.mod: $WORK\gopath\src\go.mod:5: require golang.org/x/text: version "14c0d48ead0c" invalid: must be of the form v1.2.3
            [exit status 1]
            > stderr 'go list -m: example.com@v0.0.0 \(replaced by \./\..\): parsing ../go.mod: '$WORK'/gopath/src/go.mod:5: require golang.org/x/text: version "14c0d48ead0c" invalid: must be of the form v1.2.3'
            FAIL: testdata\script\mod_invalid_version.txt:22: no match for `(?m)go list -m: example.com@v0.0.0 \(replaced by \./\..\): parsing ../go.mod: \$WORK/gopath/src/go.mod:5: require golang.org/x/text: version "14c0d48ead0c" invalid: must be of the form v1.2.3` found in stderr

FAIL
FAIL    cmd/go  626.033s
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. OS-Windows NeedsFix The path to resolution is known, but the work has not been done. labels Jun 10, 2021
@bcmills bcmills added this to the Go1.17 milestone Jun 10, 2021
@bcmills bcmills self-assigned this Jun 10, 2021
@gopherbot
Copy link

Change https://golang.org/cl/326869 mentions this issue: cmd/go: match Windows paths in TestScript/mod_invalid_version

@golang golang locked and limited conversation to collaborators Jun 11, 2022
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

2 participants