Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/release: linux-armv6l release tests aren't passing [1.15 backport] #46684

Closed
gopherbot opened this issue Jun 10, 2021 · 3 comments
Closed

x/build/cmd/release: linux-armv6l release tests aren't passing [1.15 backport] #46684

gopherbot opened this issue Jun 10, 2021 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.15.14

Comments

@gopherbot
Copy link

@cagedmantis requested issue #43202 to be considered for backport to the next 1.15 minor release.

@gopherbot please consider this for backport to 1.15
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 10, 2021
@gopherbot gopherbot mentioned this issue Jun 10, 2021
Closed
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 10, 2021
@gopherbot gopherbot modified the milestones: Unreleased, Go1.15.14 Jun 10, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/326711 mentions this issue: [release-branch.go1.15] cmd/link: pass arch-specific flags to external linker when testing supported flag

@heschi heschi added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jun 10, 2021
@heschi
Copy link
Contributor

heschi commented Jun 10, 2021

Approved.

@gopherbot
Copy link
Author

Closed by merging b4a2af2 to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Jun 10, 2021
@cherrymui @cagedmantis
[release-branch.go1.15] cmd/link: pass arch-specific flags to externa…
b4a2af2 
…l linker when testing supported flag

When testing if a flag (e.g. "-no-pie") is supported by the
external linker, pass arch-specific flags (like "-marm").

In particular, on the ARM builder, if CGO_LDFLAGS=-march=armv6
is set, the C toolchain fails to build if -marm is not passed.

	# cc -march=armv6 1.c
	1.c: In function 'main':
	1.c:3:1: sorry, unimplemented: Thumb-1 hard-float VFP ABI
	 int main() {
	 ^~~

This makes the Go linker think "-no-pie" is not supported when it
actually is.

Passing -marm makes it work.

Fixes #46684.

Change-Id: I4e8b71f08818993cbbcb2494b310c68d812d6b50
Reviewed-on: https://go-review.googlesource.com/c/go/+/278592
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
(cherry picked from commit a318d56)
Reviewed-on: https://go-review.googlesource.com/c/go/+/326711
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.15.14
Development

No branches or pull requests
2 participants
@gopherbot @heschi