Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: include modifiers in completion candidate labels #46671

Open
muirdm opened this issue Jun 9, 2021 · 2 comments
Open

x/tools/gopls: include modifiers in completion candidate labels #46671

muirdm opened this issue Jun 9, 2021 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@muirdm
Copy link

muirdm commented Jun 9, 2021

Consider whether gopls should include full expressions in candidate labels. For example:

var foo func() int
var bar *int
var _ int = <>

At <> we currently offer candidates with labels foo and bar (as of https://go-review.googlesource.com/c/tools/+/323449), but they are inserted as foo() and *bar. We could change their labels to foo() and *bar, respectively.

There will be lots of test fallout from this change. We should consider changing the mark based completion tests to depend less directly on the candidate labels.

/cc @findleyr

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 9, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jun 9, 2021
@stamblerre stamblerre modified the milestones: Unreleased, gopls/unplanned Jun 9, 2021
@findleyr findleyr modified the milestones: Unreleased, gopls/unplanned Jun 11, 2021
@danishprakash
Copy link

I'd like to take this up @muirdm

@muirdm
Copy link
Author

muirdm commented Jun 23, 2021

Go for it. The main challenges are dealing with the tests, and making sure the labels are correct when snippets are disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

5 participants