Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: greetings.Hellos(names) invocation changed, but it's not highlighted #46642

Closed
derrickstaten opened this issue Jun 7, 2021 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@derrickstaten
Copy link

derrickstaten commented Jun 7, 2021

Summary

On page https://golang.org/doc/tutorial/greetings-multiple-people, I'd expect the line messages, err := greetings.Hellos(names) to be bolded and in blue (i.e. rgb(0, 125, 156)), rather than in the default black font. This is because the function invocation greetings.Hello has been changed to greetings.Hellos in this step of the tutorial

What version of Go are you using (go version)?

$ go version
go version go1.16.5 darwin/amd64

Does this issue reproduce with the latest release?

It's a website formatting issue, not dependent on the go version

What operating system and processor architecture are you using (go env)?

It's a website formatting issue, not dependent on the go version

What did you do?

Visited https://golang.org/doc/tutorial/greetings-multiple-people and worked through the tutorial

What did you expect to see?

The following bolded, with color blue (i.e. rgb(0, 125, 156))

messages, err := greetings.Hellos(names)

What did you see instead?

The following in the normal formatting:

messages, err := greetings.Hellos(names)
@gopherbot gopherbot added this to the Unreleased milestone Jun 7, 2021
@derrickstaten
Copy link
Author

Also, the line fmt.Println(messages) should be bolded and in blue as well

@ALTree
Copy link
Member

ALTree commented Jun 8, 2021

Note: this would be fixed by cl 277454, currently under review (waiting for the author).

cl 311329 , too.

@ALTree ALTree changed the title x/website: x/website: greetings.Hellos(names) invocation changed, but it's not highlighted Jun 8, 2021
@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 8, 2021
@dmitshur
Copy link
Contributor

dmitshur commented Jun 8, 2021

Thanks for reporting. If I understand it correctly, this is a duplicate of #46416.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants