-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/pprof: runtime error: slice bounds out of range on "view source" #46636
Comments
Same thing without the webserver complexity:
|
It is interesting that |
I don't think The immediate problem seems to be that vendored pprof is invoking Still digging into why that is. |
A possible culprit is 68327e1. Does reverting it fixes it? |
I believe the problem is that https://go-review.googlesource.com/c/go/+/318049/3/src/cmd/pprof/pprof.go makes ObjAddr unconditionally return 0, but https://go-review.googlesource.com/c/go/+/318049/3/src/cmd/vendor/github.com/google/pprof/internal/report/source.go passes the result of ObjAddr to Disasm as-is. I believe that ObjAddr should return addr to remain a no-op as before. |
Yup, that does it. I'll send a CL. |
Change https://golang.org/cl/325809 mentions this issue: |
Reported at https://groups.google.com/g/golang-dev/c/MH_e2xnSWAE/m/cCPpbtb8AQAJ
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
No
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
https://play.golang.org/p/ASWkOjkKSN-
$ go tool pprof -http :8080 ./prof cpu.profile
, then browse to http://localhost:8080/ui/sourceWhat did you expect to see?
Source
What did you see instead?
The text was updated successfully, but these errors were encountered: