Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Docs not updated after charging my Github username #46623

Closed
remyduthu opened this issue Jun 7, 2021 · 5 comments
Closed

x/pkgsite: Docs not updated after charging my Github username #46623

remyduthu opened this issue Jun 7, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite

Comments

@remyduthu
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.16.4 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/remyduthu/Library/Caches/go-build"
GOENV="/Users/remyduthu/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/remyduthu/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/remyduthu/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.16.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.16.4/libexec/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16.4"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/dl/z97t194j3xv19z0jljyyrksm0000gn/T/go-build3456480264=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Enter https://pkg.go.dev/github.com/remyduthu/faces in my browser.

What did you expect to see?

The documentation for the new repository: https://github.com/remyduthu/faces.

What did you see instead?

The documentation for the old repository (redirection): https://github.com/remydt/faces.

@gopherbot gopherbot added this to the Unreleased milestone Jun 7, 2021
@jba jba self-assigned this Jun 7, 2021
@jba jba added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 7, 2021
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Jun 7, 2021
@remyduthu
Copy link
Author

remyduthu commented Jun 7, 2021

Perhaps the easiest way to fix it would be to delete the old documentation? That's not a problem as the actual package is not currently used.

@jba
Copy link
Contributor

jba commented Jun 7, 2021

It looks like you changed the tag on the new repo, which tends to confuse things.

Right now, the go.mod file in the new repo at v1.0.0 has a module path that matches the repo.

However, at some point the module path referred to the old repo, and that is the version that the proxy knows about:

> curl -L -o faces.zip https://proxy.golang.org/github.com/remyduthu/faces/@v/v1.0.0.zip
> unzip faces.zip
> cat github.com/remyduthu/faces@v1.0.0/go.mod
module github.com/remydt/faces
...

When pkgsite notices that the module path doesn't match the go.mod contents, it redirects you to the path in the go.mod file. That explains the gray banner "Redirected from github.com/remyduthu/faces" when you visit https://github.com/remyduthu/faces.

What you should have done is made a new tag when you changed the go.mod file. You can still do that: just tag master v1.0.1 and go get it, and soon pkgsite should show the right path.

Closing, but re-open if there are still problems after doing that.

@jba jba closed this as completed Jun 7, 2021
@jba
Copy link
Contributor

jba commented Jun 7, 2021

Perhaps the easiest way to fix it would be to delete the old documentation? That's not a problem as the actual package is not currently used.

I could also remove the path github.com/remydt and all sub-paths from the site, but that wouldn't fix the problem I described above. I think we'd just redirect to a 404.

Would you like me to remove github.com/remydt?

@remyduthu
Copy link
Author

Yes please, remove the old github.com/remydt repository. Thanks!

@jba
Copy link
Contributor

jba commented Jun 7, 2021

Done. https://pkg.go.dev/github.com/remyduthu/faces now returns a 404.

@golang golang locked and limited conversation to collaborators Jun 7, 2022
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Development

No branches or pull requests

3 participants