Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test case for runtime type identity for generics instantiated with anonymous struct literals with tags #46591

Closed
mdempsky opened this issue Jun 5, 2021 · 3 comments
Closed

test: add test case for runtime type identity for generics instantiated with anonymous struct literals with tags #46591

mdempsky opened this issue Jun 5, 2021 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.18

Comments

@mdempsky
Copy link
Member

mdempsky commented Jun 5, 2021

This program should print 2: https://go2goplay.golang.org/p/CC066DjHD5x

cmd/compile gets this right, but cmd/go2go prints 1.

/cc @ianlancetaylor @griesemer (thx @dominikh for test case)
@griesemer
Copy link
Contributor

The go2go playground is not actively supported anymore.
But we should probably add a test case for the compiler, just to cover this.
cc: @ianlancetaylor

@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 7, 2021
@cherrymui cherrymui added this to the Go1.18 milestone Jun 7, 2021
@cherrymui cherrymui changed the title cmd/go2go: bad runtime type identity for generics instantiated with anonymous struct literals with tags test: add test case for runtime type identity for generics instantiated with anonymous struct literals with tags Jun 7, 2021
@cherrymui
Copy link
Member

As noted, cmd/go2go is not actively supported now. Leave the issue open for adding the test case. Thanks.

@gopherbot
Copy link

Change https://golang.org/cl/343970 mentions this issue: test/typeparam: add a test case for issue46591

@golang golang locked and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@mdempsky @griesemer @gopherbot @cherrymui