Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto: missing git tags with proper version semantics (vX.X.X) #46580

Closed
qeubar opened this issue Jun 4, 2021 · 1 comment
Closed

x/crypto: missing git tags with proper version semantics (vX.X.X) #46580

qeubar opened this issue Jun 4, 2021 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@qeubar
Copy link

qeubar commented Jun 4, 2021

What version of Go are you using (go version)?

$ go version
go version 1.16.4 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="auto"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/vagrant/.cache/go-build"
GOENV="/home/vagrant/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/vagrant/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/vagrant/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/golang1.16/lib/golang"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/golang1.16/lib/golang/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="1.16.4"
GCCGO="gccgo"
AR="ar"
CC="/opt/gcc8/bin/gcc8"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3330331572=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Using the golang.org/x/crypto pkg and noticed that it doesn't use the standard Go Modules versioning. Ie, the repository does not have any git tags.

What did you expect to see?

Proper git tags (vX.X.X) on golang.org/x/crypto so one can easily identify which version of the pkg they are using.

What did you see instead?

golang.org/x/crypto was updated to have a go.mod file but never went the full path of adding git tags with proper version semantics.
@gopherbot gopherbot added this to the Unreleased milestone Jun 4, 2021
@seankhliao
Copy link
Member

Duplicate of #21324

@seankhliao seankhliao marked this as a duplicate of #21324 Jun 4, 2021
@golang golang locked and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@qeubar @gopherbot @seankhliao