Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: ICE on sorting interfaces that embed both defined and anonymous types #46556

Closed
mdempsky opened this issue Jun 3, 2021 · 1 comment
Closed

cmd/compile: ICE on sorting interfaces that embed both defined and anonymous types #46556

mdempsky opened this issue Jun 3, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.18

Comments

@mdempsky
Copy link
Member

mdempsky commented Jun 3, 2021

Pointed out by @danscales on golang.org/cl/324330, this test case now fails to compile because Sym.Less doesn't handle sorting A and B.

package p

type A = interface {}
type B interface {}
type C interface { A; B }
@mdempsky mdempsky added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 3, 2021
@mdempsky mdempsky self-assigned this Jun 3, 2021
@mdempsky mdempsky added this to the Go1.18 milestone Jun 3, 2021
@gopherbot
Copy link

Change https://golang.org/cl/324812 mentions this issue: [dev.typeparams] cmd/compile: allow nil Syms in Sym.Less

gopherbot pushed a commit that referenced this issue Jun 3, 2021
@mdempsky
[dev.typeparams] cmd/compile: allow nil Syms in Sym.Less
026480d 
Allows sorting interfaces that contain embedded anonymous types.

Fixes #46556.

Change-Id: If19afa1d62432323b2e98957087867afbf3f9097
Reviewed-on: https://go-review.googlesource.com/c/go/+/324812
Trust: Matthew Dempsky <mdempsky@google.com>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
@mdempsky mdempsky closed this as completed Jun 3, 2021
@golang golang locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
2 participants
@mdempsky @gopherbot