Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/fuzz: add missing supported GOOS to internal/fuzz/sys_posix.go [freeze exception] #46554

Closed
dchapes opened this issue Jun 3, 2021 · 7 comments
Closed

internal/fuzz: add missing supported GOOS to internal/fuzz/sys_posix.go [freeze exception] #46554

dchapes opened this issue Jun 3, 2021 · 7 comments
Labels
FeatureRequest FrozenDueToAge fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.18

Comments

@dchapes
Copy link

dchapes commented Jun 3, 2021 •
edited

Currently src/internal/fuzz/sys_posix.go only has build constraints for darwin linux.
When I add the missing freebsd constraint it works perfectly fine for me on freebsd/amd64 (FreeBSD 11.4).
I imagine it also works on the other BSDs as well, they are all reasonably POSIX compliant.

In future, in announcements such as the one on the Go Blog, please include a sentence somewhere if the list of GOOS/GOARCH supported is limited! Believe it or not, there is a thriving world outside of Mac and Linux. It's a pain in the butt to go through the effort of downloading the dev.fuzz branch on a slow link to get nothing but an uninformative panic: not implemented and a stack trace!
@dr2chase
Copy link
Contributor

dr2chase commented Jun 4, 2021

I don't think it was tested across all the other OSes (yet), so "supported" might be too strong a word just yet. Good to know that it works, though.

@dr2chase dr2chase added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jun 4, 2021
@katiehockman
Copy link
Contributor

/cc @golang/fuzzing

@katiehockman katiehockman added fuzz Issues related to native fuzzing support NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jun 7, 2021
@katiehockman katiehockman removed their assignment Jun 7, 2021
ayang64 added a commit to ayang64/go that referenced this issue Jun 28, 2021
@ayang64
[dev.fuzz] internal/fuzz - enable fuzzing for freebsd
32f117d 
This commit adds the freebsd GOOS to the list of build tags for the
posix calls related to fuzzing.

Fixes golang#46554

Change-Id: I70b7ba89d352fafa6f79d982916f5d70358795b9

[dev.fuzz] x

Change-Id: I8cde707d65a22e9f06c7c98743578f626fe60b86
@ayang64 ayang64 mentioned this issue Jun 28, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/325209 mentions this issue: [dev.fuzz] internal/fuzz: enable fuzzing for freebsd

@katiehockman katiehockman changed the title [dev.fuzz] add missing supported GOOS to internal/fuzz/sys_posix.go [dev.fuzz] internal/fuzz: add missing supported GOOS to internal/fuzz/sys_posix.go Jun 29, 2021
@katiehockman katiehockman added this to the Backlog milestone Sep 14, 2021
@rsc rsc changed the title [dev.fuzz] internal/fuzz: add missing supported GOOS to internal/fuzz/sys_posix.go internal/fuzz: add missing supported GOOS to internal/fuzz/sys_posix.go Sep 21, 2021
@katiehockman katiehockman changed the title internal/fuzz: add missing supported GOOS to internal/fuzz/sys_posix.go internal/fuzz: add missing supported GOOS to internal/fuzz/sys_posix.go [freeze exception] Jan 11, 2022
@katiehockman
Copy link
Contributor

CC @golang/release
Requesting a freeze exception to support coverage instrumentation with FreeBSD. This will only affect fuzzing, not the default behavior of go test. https://go-review.googlesource.com/c/go/+/325209/ is the CL (it needs to be cherrypicked to master)

ayang64 added a commit to ayang64/go that referenced this issue Jan 11, 2022
@ayang64
cmd/go: enable fuzz testing for FreeBSD
285cc73 
Add "freebsd" to GOOS that sys.FuzzSupported() returns true for.

Fixes: golang#46554
@ayang64 ayang64 mentioned this issue Jan 11, 2022
Closed
ayang64 added a commit to ayang64/go that referenced this issue Jan 11, 2022
@ayang64
cmd/go: enable fuzz testing for FreeBSD
173d6fd 
Add "freebsd" to GOOS for which sys.FuzzSupported() returns true
and add freebsd to the build tags to fuzz test source.

Fixes: golang#46554
@gopherbot
Copy link

Change https://golang.org/cl/377855 mentions this issue: cmd/go: enable fuzz testing for FreeBSD

@bcmills bcmills added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jan 12, 2022
@bcmills bcmills modified the milestones: Backlog, Go1.18 Jan 12, 2022
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 12, 2022
@bcmills
Copy link
Contributor

bcmills commented Jan 12, 2022

(This is a release-blocker in the sense that it needs a decision on the freeze exception. If the freeze exception is not granted, we can move it to the Go1.19 milestone.)

@heschi
Copy link
Contributor

heschi commented Jan 12, 2022

Approved -- this is a small change to a new feature with low risk.

@dmitshur dmitshur removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jan 12, 2022
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 12, 2022
jproberts pushed a commit to jproberts/go that referenced this issue Jun 21, 2022
@ayang64 @jproberts
cmd/go: enable fuzz testing for FreeBSD
ed9555a 
Add "freebsd" to GOOS for which sys.FuzzSupported() returns true
and add freebsd to the build tags to fuzz test source.

Fixes golang#46554
Change-Id: I5f695ecc8f09c0ab4279ced23b4715b788fcade0
Reviewed-on: https://go-review.googlesource.com/c/go/+/377855
Trust: Bryan Mills <bcmills@google.com>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
@golang golang locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Go Security
Status: No status
Milestone
Go1.18
Development

Successfully merging a pull request may close this issue.

cmd/go: enable fuzz testing for FreeBSD ayang64/go
7 participants
@dmitshur @dr2chase @dchapes @bcmills @gopherbot @heschi @katiehockman