Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: Unix dnsclient test for CVE-2021-33195 assumes that 1.2.3.4 does not resolve [1.15 backport] #46531

Closed
cagedmantis opened this issue Jun 2, 2021 · 3 comments
Closed

net: Unix dnsclient test for CVE-2021-33195 assumes that 1.2.3.4 does not resolve [1.15 backport] #46531

cagedmantis opened this issue Jun 2, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.15.13

Comments

@cagedmantis
Copy link
Contributor

@neild requested issue #46504 to be considered for backport to the next 1.15 minor release.

@gopherbot please backport to 1.15
@cagedmantis cagedmantis added the CherryPickCandidate Used during the release process for point releases label Jun 2, 2021
@cagedmantis cagedmantis added this to the Go1.15.13 milestone Jun 2, 2021
@cagedmantis cagedmantis mentioned this issue Jun 2, 2021
Closed
@cagedmantis
Copy link
Contributor Author

This change is in support of a previously submitted change. It is also just an update to a test. For those reasons, it is approved.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Jun 2, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 2, 2021
@gopherbot
Copy link

Change https://golang.org/cl/324333 mentions this issue: [release-branch.go1.15] net: don't rely on system hosts in TestCVE202133195

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 2, 2021
@gopherbot
Copy link

Closed by merging 6b411e9 to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Jun 2, 2021
@rolandshoemaker @ianlancetaylor
[release-branch.go1.15] net: don't rely on system hosts in TestCVE202…
6b411e9 
…133195

Also don't unnecessarily deref the error return.

Updates #46504
Fixes #46531

Change-Id: I22d14ac76776f8988fa0774bdcb5fcd801ce0185
Reviewed-on: https://go-review.googlesource.com/c/go/+/324190
Trust: David Chase <drchase@google.com>
Trust: Damien Neil <dneil@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
(cherry picked from commit dd7ba3b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/324333
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.15.13
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot