Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages/packagestest: TestGOPATHExport and TestModulesExport are failing on Plan 9 #46503

Closed
fhs opened this issue Jun 1, 2021 · 2 comments
Closed

x/tools/go/packages/packagestest: TestGOPATHExport and TestModulesExport are failing on Plan 9 #46503

fhs opened this issue Jun 1, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9 Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@fhs
Copy link
Contributor

fhs commented Jun 1, 2021 

--- FAIL: TestGOPATHExport (0.05s)
    gopath_test.go:15: symlink testdata/a.go /tmp/TestGOPATHExport3852585505/fake1/src/golang.org/fake1/a.go: not supported by plan 9
--- FAIL: TestModulesExport (0.01s)
    modules_test.go:17: symlink testdata/a.go /tmp/TestModulesExport828457641/fake1/a.go: not supported by plan 9
FAIL
FAIL	golang.org/x/tools/go/packages/packagestest	5.750s

(from https://storage.googleapis.com/go-build-log/27255227/plan9-arm_854b9959.log)

@gopherbot add labels OS-Plan9, NeedsInvestigation
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 1, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jun 1, 2021
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9 labels Jun 1, 2021
@bcmills bcmills mentioned this issue Jun 2, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/234112 mentions this issue: go/packages/packagestest: make Export skip tests involving unsupported links

@bcmills bcmills self-assigned this Jun 2, 2021
@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 2, 2021
@bcmills
Copy link
Contributor

bcmills commented Jun 2, 2021

I already had a fix for this ready in CL 234112, so I just dusted it off and I'll submit it if it passes TryBots.

rinchsan pushed a commit to rinchsan/gosimports that referenced this issue Oct 9, 2021
@rinchsan
go/packages/packagestest: make Export skip tests involving unsupporte…
12b7914 
…d links

Also make Export create all parent directories before all files.
If the files are symlinks to directories, the target directory must
exist before the symlink is created on Windows. Otherwise, the symlink
will be created with the wrong type (and thus broken).

Fixes golang/go#46503
Updates golang/go#38772
Updates golang/go#39183

Change-Id: I17864ed66e0464e0ed1f56c55751b384b8c59484
Reviewed-on: https://go-review.googlesource.com/c/tools/+/234112
Trust: Bryan C. Mills <bcmills@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
@golang golang locked and limited conversation to collaborators Jun 2, 2022
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9 Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@fhs @bcmills @gopherbot