Skip to content

x/website: build broken since CL 322790 #46501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Jun 1, 2021 · 5 comments
Closed

x/website: build broken since CL 322790 #46501

bcmills opened this issue Jun 1, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.17

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 1, 2021

https://build.golang.org/log/777f4be48c19e0f1f4b2ebf33996073bc16b648f:

linux-amd64 at 24e9707cbfa6b1ed6abdd4b11f9ddaf3aac5ad88 building website at 64052e727d3c16a4b177c77c4dd01b877533f549

testing in module mode; GOMOD=/workdir/gopath/src/golang.org/x/website/go.mod

:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/website/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn383beaa" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.50:30157" "GO111MODULE=on" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/website

go: downloading cloud.google.com/go/datastore v1.2.0
go: downloading github.com/gomodule/redigo v2.0.0+incompatible
go: downloading golang.org/x/build v0.0.0-20210422214718-6469a76194d9
go: downloading golang.org/x/tools v0.1.1-0.20210215123931-123adc86bcb6
go: downloading golang.org/x/net v0.0.0-20201110031124-69a78807bb2b
go: downloading cloud.google.com/go v0.58.0
go: downloading github.com/yuin/goldmark v1.2.1
go: downloading github.com/golang/protobuf v1.4.3
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading google.golang.org/api v0.27.0
go: downloading google.golang.org/genproto v0.0.0-20200617032506-f1bdc9086088
go: downloading google.golang.org/grpc v1.33.2
go: downloading go.opencensus.io v0.23.0
go: downloading google.golang.org/protobuf v1.25.0
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading golang.org/x/sys v0.0.0-20210124154548-22da62e12c0c
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/google/go-cmp v0.5.5
go: downloading golang.org/x/text v0.3.3
?   	golang.org/x/website	[no test files]
?   	golang.org/x/website/cmd/admingolangorg	[no test files]
ok  	golang.org/x/website/cmd/golangorg	1.586s
?   	golang.org/x/website/cmd/googlegolangorg	[no test files]
ok  	golang.org/x/website/internal/api	0.108s
ok  	golang.org/x/website/internal/dl	0.044s
?   	golang.org/x/website/internal/env	[no test files]
ok  	golang.org/x/website/internal/godoc	0.202s
ok  	golang.org/x/website/internal/history	0.026s
ok  	golang.org/x/website/internal/memcache	0.049s
ok  	golang.org/x/website/internal/pkgdoc	0.270s
?   	golang.org/x/website/internal/proxy	[no test files]
ok  	golang.org/x/website/internal/redirect	5.179s
ok  	golang.org/x/website/internal/short	0.011s
ok  	golang.org/x/website/internal/spec	0.013s
?   	golang.org/x/website/internal/texthtml	[no test files]
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/website/blog/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn383beaa" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.50:30157" "GO111MODULE=on" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/website/blog

go: downloading golang.org/x/website v0.0.0-20200611220721-d72cde69aaaf
go: downloading golang.org/x/tools v0.1.1-0.20210427153610-6397a11608ad
go: downloading github.com/yuin/goldmark v1.3.3
ok  	golang.org/x/website/blog	0.190s
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/website/go.dev/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn383beaa" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.50:30157" "GO111MODULE=on" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/website/go.dev

go: warning: "golang.org/x/website/go.dev/..." matched no packages
no packages to test
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/website/tour/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn383beaa" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.50:30157" "GO111MODULE=on" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/website/tour

go: warning: "golang.org/x/website/tour/..." matched no packages
no packages to test

It's not obvious to me whether this is a problem in the x/website repo or something to do with how cmd/coordinator identifies which modules to test.

CC @golang/release
@gopherbot gopherbot added this to the Unreleased milestone Jun 1, 2021
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. labels Jun 1, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Jun 1, 2021

(Release blocker via #11811.)

@bcmills bcmills added okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Jun 1, 2021
@bcmills bcmills modified the milestones: Unreleased, Go1.17 Jun 1, 2021
@bcmills bcmills added the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Jun 1, 2021
@dmitshur
Copy link
Contributor

dmitshur commented Jun 2, 2021

It's not obvious to me whether this is a problem in the x/website repo or something to do with how cmd/coordinator identifies which modules to test.

To provide clarity, the build is considered to fail because coordinator runs go test {module/path}/... for each module root it finds, and the go command exits with a non-zero exit code when go test pattern matches no packages.

In this case, no packages are matched in the blog and go.dev nested modules because their go.mod file hasn't been updated to the newer module path after the move to x/website:


$ cd website/blog
$ go list ./... | head -3
golang.org/x/tour
golang.org/x/tour/content
golang.org/x/tour/gotour
$ go test golang.org/x/website/tour/...
go: warning: "golang.org/x/website/tour/..." matched no packages
no packages to test
$ echo $?
1

Russ has already included a fix in a stack of CLs, I'll get to reviewing it soon.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/324411 mentions this issue: go.dev: fix module path to make trybots happy

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/324395 mentions this issue: tour: fix go.mod module path

gopherbot pushed a commit to golang/website that referenced this issue Jun 2, 2021
@rsc
go.dev: fix module path to make trybots happy
52dfb42 
For golang/go#46501.

Change-Id: Ie2adbc3536570e66ffda1227ffd4431fe4bf870a
Reviewed-on: https://go-review.googlesource.com/c/website/+/324411
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Website-Publish: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/website that referenced this issue Jun 2, 2021
@rsc
tour: fix go.mod module path

Verified

This commit was signed with the committer’s verified signature.
ruyadorno Ruy Adorno
GPG key ID: E7DC4C5493C3DB5F
Verified
Learn about vigilant mode
b593c13 
The supporting packages (pic, reader, tree, wc) are still
in golang.org/x/tour, so delete these copies.

Fix the remaining references in local.go to use
golang.org/x/website/tour instead of golang.org/x/tour
to find the content files.

While we are here, make go test ./... considerably faster
by parallelizing TestContent.

For golang/go#46501.

Change-Id: Ia80161830f5f2f87fb6e39a0ee39c4b176fb425b
Reviewed-on: https://go-review.googlesource.com/c/website/+/324395
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Website-Publish: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/324510 mentions this issue: go.dev/cmd/internal/site: fix tests on Windows

@golang golang locked and limited conversation to collaborators Jun 3, 2022
@rsc rsc unassigned rsc and dmitshur Jun 23, 2022
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
go.dev/cmd/internal/site: fix tests on Windows

Verified

This commit was signed with the committer’s verified signature.
ruyadorno Ruy Adorno
GPG key ID: E7DC4C5493C3DB5F
Verified
Learn about vigilant mode
79f5127 
The site will never run on Windows, but keeping the tests passing
makes the x/website TryBots happy, and it is easy to do.

Fixes golang/go#46501.

Change-Id: Ib9ea07dc4164fbea38b7624c32a6f46d7bab6739
Reviewed-on: https://go-review.googlesource.com/c/website/+/324510
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Website-Publish: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
4 participants
@rsc @dmitshur @bcmills @gopherbot