Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/updatecontrib: add vscode-go and vulndb contributors to list of Go contributors #46487

Closed
cagedmantis opened this issue Jun 1, 2021 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. release-blocker
Milestone

Comments

@cagedmantis
Copy link
Contributor

We should add the following repositories to the list of repositories queried for Go contributors:

  • vscode-go
  • vulndb

@golang/release

@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) release-blocker okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Jun 1, 2021
@cagedmantis cagedmantis added this to the Go1.17 milestone Jun 1, 2021
@dmitshur
Copy link
Contributor

dmitshur commented Jun 1, 2021

These repos seem more different compared to the repositories that updatecontrib currently tracks, which are primarily golang.org/x repos with Go code. (The proposal repository is a notable exception in that it doesn't have much Go code at all.)

vscode-go is primarily written in TypeScript, does not reuse the same license as in the Go repository, and has its own contribution guide. Is it desirable for its contributors to be automatically added to the Go repository's CONTRIBUTORS file? CC @hyangah for input.

vulndb is currently described as "Neither the code, nor the data, nor the existence of this repository is to be considered stable until an approved proposal." so perhaps we need to wait for that to change before considering next steps, but CC @rolandshoemaker and @FiloSottile for early input.

@dmitshur dmitshur added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jun 1, 2021
@hyangah
Copy link
Contributor

hyangah commented Jun 8, 2021

Agree that vscode-go is distinct from other Go projects even though vscode-go follows the same contribution guide as the other Go projects

  • uses a different language
  • the project was transferred later in its lifetime
  • uses a different license

So, it's unnecessary to share the CONTRIBUTORS file.
For vscode-go project, the git history will be the best source of truth, and we acknowledge the contributors in its CHANGELOG for every release.

@cagedmantis
Copy link
Contributor Author

Thanks for the input @hyangah.

@heschi heschi removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Jun 10, 2021
@cagedmantis
Copy link
Contributor Author

We've reached the decision that neither of these repositories will be used to seed contributor data. Thank you for the feedback, this has been helpful in clarifying what should seed the data.

@golang golang locked and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. release-blocker
Projects
None yet
Development

No branches or pull requests

5 participants