Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: allow an opt-in license check bypass #46470

Closed
icholy opened this issue May 31, 2021 · 4 comments
Closed

x/pkgsite: allow an opt-in license check bypass #46470

icholy opened this issue May 31, 2021 · 4 comments

Comments

@icholy
Copy link

icholy commented May 31, 2021

What did you do?

Use a license that's not recognised by the license check tool

There are many more issues like this.

What did you expect to see?

A way to instruct the pkgsite to render the docs regardless of license. Possibly a go.mod directive.

@gopherbot gopherbot added this to the Unreleased milestone May 31, 2021
@ALTree
Copy link
Member

ALTree commented May 31, 2021

That's probably not possible. From this golang-dev thread, this segment of rsc's post explains why there's license detection:

The teams working on the proxy and on pkg.go.dev have spent a lot of
time talking to Google's lawyers about what we can and can't do with
Go source code downloaded from the internet. The rule we've been given
to follow is that serving a pretty HTML version of the docs is
displaying a modified version of the original, and we can only do that
if there's a recognized known-good license that gives us that
permission.

@icholy
Copy link
Author

icholy commented May 31, 2021

We can still work within those constraints. There could be a special/additional license file which gives the pkgsite permission to render the docs. The license would be written in a way that's compatible with proprietary licenses.

@ALTree
Copy link
Member

ALTree commented May 31, 2021

There could be a special/additional license file which gives the pkgsite permission to render the docs.

Pretty burdensome if you ask me. And the website would still need to be able to recognize that 2nd licence, which wouldn't even be a standard one... seems like we're back at square one.

cc @jba on this.

@jba
Copy link
Contributor

jba commented Jun 1, 2021

I'm sorry, I don't have any new ideas here.

We don't want to go the route where you give pkgsite special permission. That doesn't scale well to other sites and tools that have the same legal issue as we do.

If your license is not on our list, but is OSI-approved and grants the permission we need, there's a decent chance we can add it to our list. File an issue pointing to the license and we'll take a look.

@jba jba self-assigned this Jun 1, 2021
@jba jba closed this as completed Jun 1, 2021
@golang golang locked and limited conversation to collaborators Jun 1, 2022
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants