Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: 'comparable' still in universe scope for 1.17 #46453

Closed
findleyr opened this issue May 30, 2021 · 1 comment
Closed

go/types: 'comparable' still in universe scope for 1.17 #46453

findleyr opened this issue May 30, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.17

Comments

@findleyr
Copy link
Contributor

The predeclared 'comparable' interface is still available in the universe scope for 1.17. It needs to be removed. Also, due to #46090, the following code type-checks without error:

package p
type _ comparable

Fix incoming.

CC @griesemer
@findleyr findleyr added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels May 30, 2021
@findleyr findleyr added this to the Go1.17 milestone May 30, 2021
@findleyr findleyr self-assigned this May 30, 2021
@gopherbot
Copy link

Change https://golang.org/cl/323609 mentions this issue: go/types: don't declare 'comparable' when typeparams are disabled

@findleyr findleyr changed the title go/types: 'comparable' in universe scope for 1.17 go/types: 'comparable' still in universe scope for 1.17 May 30, 2021
@golang golang locked and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
2 participants
@gopherbot @findleyr