Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/unix: add missing const (MTDFILEMODE) from <mtd/mtd-user.h> #46448

Closed
lhl2617 opened this issue May 29, 2021 · 1 comment
Closed

x/sys/unix: add missing const (MTDFILEMODE) from <mtd/mtd-user.h> #46448

lhl2617 opened this issue May 29, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@lhl2617
Copy link

lhl2617 commented May 29, 2021

What did you expect to see?

#46063 added most of these consts; however, one const--MTDFILEMODE--did not make it due to an overly strict regex in mkerrors.sh:

...
		$2 ~ /^MTD_/ ||
...

This can be trivially fixed by removing the underscore.

Apologies--I did not catch this in my CL.

@gopherbot gopherbot added this to the Unreleased milestone May 29, 2021
@lhl2617 lhl2617 changed the title x/sys/unix: add missing const from <mtd/mtd-user.h> x/sys/unix: add missing const (MTDFILEMODE) from <mtd/mtd-user.h> May 29, 2021
@gopherbot
Copy link

Change https://golang.org/cl/323391 mentions this issue: unix: add missing const (MTDFILEMODE) from <mtd/mtd-user.h>

@seankhliao seankhliao added the NeedsFix The path to resolution is known, but the work has not been done. label May 30, 2021
@golang golang locked and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants