Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: invalid completion in index expression #46436

Closed
muirdm opened this issue May 28, 2021 · 1 comment
Closed

x/tools/gopls: invalid completion in index expression #46436

muirdm opened this issue May 28, 2021 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@muirdm
Copy link

muirdm commented May 28, 2021

[]int{}[<>]

Completing at <> offers a candidate untyped int(). gopls is trying to offer a type conversion to the expected type of "untyped int", but that is nonsense. We should not offer type conversions if the expected type is untyped.

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 28, 2021
@gopherbot gopherbot added this to the Unreleased milestone May 28, 2021
@gopherbot
Copy link

Change https://golang.org/cl/323469 mentions this issue: lsp/completion: don't offer untyped conversions

@stamblerre stamblerre modified the milestones: Unreleased, gopls/unplanned Jun 1, 2021
@golang golang locked and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants