Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: changes in code not highlighted in grettings-multiple-people tutorial #46416

Closed
AaronWiora opened this issue May 27, 2021 · 8 comments
Closed

x/website: changes in code not highlighted in grettings-multiple-people tutorial #46416

AaronWiora opened this issue May 27, 2021 · 8 comments
Labels
Documentation Issues describing a change to documentation. NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
website/backlog

Comments

@AaronWiora
Copy link

AaronWiora commented May 27, 2021 •
edited by dmitshur
Loading

What did you expect to see?

On the site https://golang.org/doc/tutorial/greetings-multiple-people Step 2 in the code block:

// Request greeting messages for the names.
    messages, err := greetings.Hellos(names)

I think the font color should be blue, because this part changed from "Hello" to "Hellos".

What did you see instead?

Font color is black.
@gopherbot gopherbot added this to the Unreleased milestone May 27, 2021
@AaronWiora AaronWiora changed the title x/website: x/website: Changes in code not marked with blue font color May 27, 2021
@mknyszek mknyszek changed the title x/website: Changes in code not marked with blue font color x/website: changes in code not highlighted in grettings-multiple-people tutorial May 27, 2021
@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label May 27, 2021
@mknyszek
Copy link
Contributor

I think this is right, unless I'm misunderstanding the tutorial.

CC @dmitshur

@dmitshur
Copy link
Contributor

I agree, this can be improved. There's already CL 311329 that was sent earlier that should address this issue. It just needs to be reviewed.

@dmitshur dmitshur mentioned this issue Jun 8, 2021
Closed
@dmitshur
Copy link
Contributor

dmitshur commented Jun 8, 2021

As @ALTree pointed out in #46642 (comment), CL 277454 is another open CL that would fix this issue.

@dmitshur dmitshur added the Documentation Issues describing a change to documentation. label Jun 8, 2021
@dmitshur dmitshur mentioned this issue Jul 14, 2021
Closed
@ALTree ALTree mentioned this issue Aug 26, 2021
Closed
This was referenced Nov 21, 2021
Closed
Closed
@seankhliao seankhliao mentioned this issue May 9, 2022
Closed
@seankhliao seankhliao mentioned this issue Jun 9, 2022
Closed
@jamalc
Copy link

jamalc commented Jun 15, 2022

Closing as obsolete, golang.org has been merged into go.dev.

@jamalc jamalc closed this as completed Jun 15, 2022
@fzipp
Copy link
Contributor

fzipp commented Jun 15, 2022

@jamalc But the issue still exists on go.dev. Newbies seem to find it confusing enough that they create a new issue every couple of weeks.

@seankhliao
Copy link
Member

Reopening since the issue is still there, just in a different location https://go.dev/doc/tutorial/greetings-multiple-people

@seankhliao seankhliao reopened this Jun 15, 2022
@jamalc jamalc modified the milestones: Unreleased, website/later Jun 15, 2022
@jamalc
Copy link

jamalc commented Jun 15, 2022

I'll take a look at the CLs.

@annagroebel
Copy link

I think the issue is resolved:
Screenshot 2025-01-08 at 15 10 39
@seankhliao @jamalc Can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Milestone
website/backlog
Development

No branches or pull requests
8 participants
@fzipp @mknyszek @dmitshur @gopherbot @seankhliao @AaronWiora @jamalc @annagroebel