Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: audit error messages for go1.17 #46404

Closed
findleyr opened this issue May 26, 2021 · 4 comments
Closed

go/types: audit error messages for go1.17 #46404

findleyr opened this issue May 26, 2021 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.17

Comments

@findleyr
Copy link
Contributor

With all the changes to go/types merged from the dev.typeparams branch, many error messages have changed. In general these were all intentional improvements, but we should try to ensure that no error messages related to generics leak in 1.17. Such errors are marked, so fuzz testing might be helpful here, in addition to manual auditing.

CC @griesemer
@findleyr findleyr added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels May 26, 2021
@findleyr findleyr added this to the Go1.17 milestone May 26, 2021
@findleyr findleyr self-assigned this May 26, 2021
@heschi heschi removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Jun 10, 2021
@toothrot
Copy link
Contributor

@findleyr We're close to RC1, and this issue is a release blocker. Any updates?

@findleyr
Copy link
Contributor Author

Same as #46403. For this, I just need to do a bit of due diligence. Barring surprises, I can close this out by Monday.

@gopherbot
Copy link

Change https://golang.org/cl/329793 mentions this issue: go/types: guard against checking instantiation when generics is disabled

@findleyr
Copy link
Contributor Author

Update: this can be closed once CL 329793 is merged. Fuzzing found this test case relatively quickly, and did not find any others after a long time.

I also checked for leaks in our existing test data corpus. I feel satisfied that we've done our due diligence.

gopherbot pushed a commit that referenced this issue Jun 22, 2021
@findleyr
go/types: guard against checking instantiation when generics is disabled
63daa77 
When type checking t[_], where t is a type name, it was possible to leak
an error message related to generics. Fix this by guarding on
typeparams.Enabled.

In order to test this fix, we need to be able to run the new go/types
test only if type parameters are disabled. Introduce the .go1 test data
suffix (similar to .go2) to control this behavior.

Originally found via fuzzing, though the test case was manually
simplified.

Updates #46404

Change-Id: Ib1e2c27cf974c2a5ca5b9d6d01b84a30ba4d583b
Reviewed-on: https://go-review.googlesource.com/c/go/+/329793
Trust: Robert Findley <rfindley@google.com>
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
@golang golang locked and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
4 participants
@toothrot @gopherbot @heschi @findleyr