Skip to content

x/tools/gopls: bad variadic completion ordering #46378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
muirdm opened this issue May 26, 2021 · 1 comment
Closed

x/tools/gopls: bad variadic completion ordering #46378

muirdm opened this issue May 26, 2021 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.7.0

Comments

@muirdm
Copy link

muirdm commented May 26, 2021 

func FallOut2() (int, int) {
	return 0, 0
}

func FallOut1() int {
	return 0
}

func main() {
	foo := 123
	fmt.Println(fo<>)
}

At <>, FallOut2 is ranked above foo. I think foo should be the top candidate. gopls seems to be preferring FallOut2's multiple return values in the variadic context.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 26, 2021
@gopherbot gopherbot added this to the Unreleased milestone May 26, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/323509 mentions this issue: lsp/completion: fix variadic param candidate ordering edge case

@golang golang locked and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.7.0
Development

No branches or pull requests
4 participants
@stamblerre @suzmue @gopherbot @muirdm