Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html/template: Documentation for func Must references template.Must #4634

Closed
campoy opened this issue Jan 8, 2013 · 3 comments
Closed

html/template: Documentation for func Must references template.Must #4634

campoy opened this issue Jan 8, 2013 · 3 comments
Labels
Documentation FrozenDueToAge
Milestone
Go1.1

Comments

@campoy
Copy link
Contributor

campoy commented Jan 8, 2013 

What steps will reproduce the problem?
1. Go to http://golang.org/pkg/html/template/#Must
2. Read the documenation

What is the expected output? What do you see instead?

I'd expect a clearer explanation than this:

"Must panics if err is non-nil in the same way as template.Must."

template.Must here is either wrong or doing a circular reference.
@kisielk
Copy link
Contributor

kisielk commented Jan 8, 2013

Comment 1:

Similar problem exists for the description of the Template type.
"Template is a specialized template.Template that produces a safe HTML document
fragment."
I assume the documentation is referring to text/template.Template in both cases?

@rsc
Copy link
Contributor

rsc commented Jan 9, 2013

Comment 2:

Yes, these refer to text/template.

@campoy
Copy link
Contributor Author

campoy commented Jan 14, 2013

Comment 3:

This issue was closed by revision 1590be9.

Status changed to Fixed.

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.1
Development

No branches or pull requests
4 participants
@kisielk @rsc @campoy @gopherbot