Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/ast: revert the added FuncDecl.IsMethod #46297

Closed
findleyr opened this issue May 20, 2021 · 3 comments
Closed

go/ast: revert the added FuncDecl.IsMethod #46297

findleyr opened this issue May 20, 2021 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.17

Comments

@findleyr
Copy link
Contributor

+pkg go/ast, method (*FuncDecl) IsMethod() bool

The IsMethod field was added to FuncDecl to report whether or not it is a method.

CC @griesemer
@findleyr findleyr added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels May 20, 2021
@findleyr findleyr added this to the Go1.17 milestone May 20, 2021
@findleyr findleyr self-assigned this May 20, 2021
@ianlancetaylor
Copy link
Contributor

As far as I can tell this is new API that was added without going through the proposal process.

Are we OK with that?

@findleyr findleyr changed the title doc/go1.17: document go/ast changes for Go 1.17 go/ast: revert the added FuncDecl.IsMethod May 28, 2021
@findleyr
Copy link
Contributor Author

This was an artifact of the dev.typeparams merge. Since it wasn't directly related to generics, it wasn't guarded by the typeparams constraint.

@griesemer and I discussed this API earlier today and decided to revert it.

@gopherbot
Copy link

Change https://golang.org/cl/323369 mentions this issue: go/ast: delete FuncDecl.IsMethod

@golang golang locked and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
3 participants
@ianlancetaylor @gopherbot @findleyr