Skip to content

proposal: cmd/go: message about deprecated modules should not be a warning by default #46294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
theckman opened this issue May 20, 2021 · 7 comments
Closed

proposal: cmd/go: message about deprecated modules should not be a warning by default #46294

theckman opened this issue May 20, 2021 · 7 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.17

Comments

@theckman
Copy link
Contributor

theckman commented May 20, 2021 •
edited
Loading

Context

The go command currently reports deprecation notices as a warning[0], even if that module version is still fully supported but the author and the Deprecation is informing consumers of a new major version (as we have no other mechanisms to communicate information to consumers).

0:

go/src/cmd/go/internal/modget/get.go

Line 1601 in 814c5ff

fmt.Fprintf(os.Stderr, "go: warning: module %s is deprecated: %s\n", mm.m.Path, mm.message)

Proposal

This proposal is to remove the word warning from the message that's printed when showing the deprecation, and leave it up to the Module author to provide the context around the severity in the deprecation message itself.
@gopherbot gopherbot added this to the Proposal milestone May 20, 2021
@seankhliao
Copy link
Member

cc @bcmills @jayconrod @matloob

@peterbourgon
Copy link

peterbourgon commented May 20, 2021 •
edited
Loading

Strong +1. I was surprised to see the word "warning" in the mesasging, because it was deliberately not part of the proposal.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/321649 mentions this issue: cmd/go: remove warning from module deprecation notice printing

@jayconrod
Copy link
Contributor

This seems okay? If everyone's fine with this, I think we should go ahead and merge that CL rather than go through the proposal process.

@bcmills bcmills modified the milestones: Proposal, Go1.17 May 21, 2021
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. release-blocker NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels May 21, 2021
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 21, 2021
@bcmills bcmills added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. and removed Proposal labels May 21, 2021
@gopherbot gopherbot removed the NeedsFix The path to resolution is known, but the work has not been done. label May 21, 2021
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label May 21, 2021
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 21, 2021
@bcmills
Copy link
Contributor

bcmills commented May 21, 2021

Agreed — I think we should just do this rather than send it through the proposal process. (It's just a rewording in the go command's output, so the proposal process seems too heavy, and since we don't guarantee output stability for the go command there are no backward- or forward-compatibility issues to worry about.)

@theckman
Copy link
Contributor Author

Works for me. I only filed it as a proposal as I wasn't sure when that decision had been made to call it a warning, relative to the original proposal, or if it was something that had mistakenly been added during the implementation.

@jayconrod
Copy link
Contributor

Ok sounds good. Submitted the CL, thanks for sending that.

I think I used "warning" just because retraction uses similar language, and the code that handles deprecation is close to that.

@golang golang locked and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
6 participants
@peterbourgon @jayconrod @theckman @bcmills @gopherbot @seankhliao