Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all, cmd/internal/moddeps: tree is inconsistent state and tests aren't reporting it #46254

Closed
dmitshur opened this issue May 19, 2021 · 2 comments
Closed

all, cmd/internal/moddeps: tree is inconsistent state and tests aren't reporting it #46254

dmitshur opened this issue May 19, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.17

Comments

@dmitshur
Copy link
Contributor

There are a few mild but unexpected inconsistencies in the tree at tip (commit 15a374d as of this posting):

Tests in cmd/internal/moddeps exist to catch this type of skew, yet longtest builders are green and these tests are passing locally:

$ gotip version
go version devel go1.17-15a374d5c Wed May 19 01:09:20 2021 +0000 darwin/amd64
$ gotip test cmd/internal/moddeps
ok  	cmd/internal/moddeps	1.045s

This is due to a recent bug in findGorootModules causing no modules to be found (similar to #46027), and therefore no modules to be tested:

$ gotip test -v cmd/internal/moddeps
=== RUN   TestAllDependencies
--- PASS: TestAllDependencies (0.38s)
=== RUN   TestDependencyVersionsConsistent
--- PASS: TestDependencyVersionsConsistent (0.00s)
PASS
ok  	cmd/internal/moddeps	0.494s

(Note no subtests run.)

I'll send a CL to fix the bug, add a safety check that at very least well-known modules are found, and get the tree into a tidy state again.

CC @golang/release, @bcmills, @findleyr, @FiloSottile.
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels May 19, 2021
@dmitshur dmitshur added this to the Go1.17 milestone May 19, 2021
@dmitshur dmitshur self-assigned this May 19, 2021
@gopherbot
Copy link

Change https://golang.org/cl/320991 mentions this issue: cmd/internal/moddeps: use filepath.SkipDir only on directories

@FiloSottile
Copy link
Contributor

Sorry, in hindsight I should have added the safety check myself in the first CL.

@golang golang locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
3 participants
@FiloSottile @dmitshur @gopherbot