Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: semanticToken legend not used when encoding #46244

Closed
leitzler opened this issue May 18, 2021 · 1 comment
Closed

x/tools/gopls: semanticToken legend not used when encoding #46244

leitzler opened this issue May 18, 2021 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.7.0

Comments

@leitzler
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version devel go1.17-756e2b1529 Fri Apr 9 19:11:12 2021 +0000 darwin/amd64
$ go list -m golang.org/x/tools golang.org/x/tools/gopls
golang.org/x/tools v0.1.1-0.20210506192834-c0140e85e11c
golang.org/x/tools/gopls v0.0.0-20210506192834-c0140e85e11c

Does this issue reproduce with the latest release?

Yes

What did you do?

Enabled semantic token support by sending token types in ClientCapabilities in any order that isn't the exact order they appear in LSP.

What did you expect to see?

Tokens types (and modifiers) encoded enumerated as gopls report as legend in the RegisterCapability request.

What did you see instead?

Incorrect value used for token type (and token modifier).
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 18, 2021
@gopherbot gopherbot added this to the Unreleased milestone May 18, 2021
@gopherbot
Copy link

Change https://golang.org/cl/321029 mentions this issue: internal/lsp: report used semantic token order in registerCapability

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.6.12 May 19, 2021
@golang golang locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.7.0
Development

No branches or pull requests
3 participants
@leitzler @stamblerre @gopherbot