Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/dist: bootstrap with gccgo fails #46240

Closed
stevenpackardblp opened this issue May 18, 2021 · 3 comments
Closed

cmd/dist: bootstrap with gccgo fails #46240

stevenpackardblp opened this issue May 18, 2021 · 3 comments
Labels
FrozenDueToAge

Comments

@stevenpackardblp
Copy link

What version of Go are you using (go version)?

Compiling 1.16.4 release source code using GCC 9.3 gccgo.

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

linux amd64

What did you do?

Attempting to build the 1.16.4 release using GCC 9.3 gccgo fails with:

GOOS=linux GOARCH=amd64 \
GOROOT=/tmp/go-1.16 \
GOROOT_FINAL=/opt/go-1.16 \
GOROOT_BOOTSTRAP=/opt/go \
GCCGO=gccgo \
./make.bash
Building Go cmd/dist using /opt/go. (go1.12.2 gccgo (9.3.0-2+b20210507T23473637) 9.3.0 linux/amd64)
Building Go toolchain1 using /opt/go.
# bootstrap/cmd/compile/internal/ssa
cmd/compile/internal/ssa/flags_amd64_test.s:11:10: fatal error: textflag.h: No such file or directory
   11 | #include "textflag.h"
      |          ^~~~~~~~~~~~
compilation terminated.

What did you expect to see?

Successful build

What did you see instead?

Failed build

This is the same regression as #40855 and #30771. This worked in 1.16.3, and has regressed in 1.16.4.
@apaprocki
Copy link

It appears that #40875 was entered to help detect/prevent this regression.

@cherrymui
Copy link
Member

This is weird. I don't think there is anything changed related to this between 1.16.3 and 1.16.4. Could you double check you're building Go 1.16.4? Maybe try ./clean.bash; ./make.bash -v=3 and paste the output? Thanks.

@cherrymui cherrymui changed the title cmd/compile: fatal error: textflag.h: No such file or directory cmd/dist: bootstrap with gccgo fails May 18, 2021
@gopherbot gopherbot added this to the Gccgo milestone May 18, 2021
@cherrymui cherrymui removed this from the Gccgo milestone May 18, 2021
@stevenpackardblp
Copy link
Author

Well, this is embarrassing. I apparently copied the 1.15.12 URL and imported it as the 1.16.4 source into our system. Once I imported the correct source, everything worked as expected, so this is totally on me. Please do consider working on #40875, though!

@golang golang locked and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@apaprocki @gopherbot @cherrymui @stevenpackardblp