Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: fix loop bounds in example to match function comments #46223

Closed
krishna-birla opened this issue May 18, 2021 · 1 comment
Closed

x/website: fix loop bounds in example to match function comments #46223

krishna-birla opened this issue May 18, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@krishna-birla
Copy link

krishna-birla commented May 18, 2021 •
edited by dmitshur

What version of Go are you using (go version)?

$ go version
go version go1.15.8 darwin/amd64

Does this issue reproduce with the latest release?

Not Applicable.

What operating system and processor architecture are you using (go env)?

Not Applicable.

What did you do?

Played with the "Concurrent pi" example at https://golang.org, https://play.golang.org/p/Ryve74AOWxA.

What did you expect to see?

The example code should launch n go routines.

What did you see instead?

The example code launches n+1 go routines.
@gopherbot gopherbot added this to the Unreleased milestone May 18, 2021
@krishna-birla krishna-birla mentioned this issue May 18, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/320032 mentions this issue: _content/doc/play: fix loop bounds to match function comments

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label May 18, 2021
@golang golang locked and limited conversation to collaborators May 27, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
_content/doc/play: fix loop bounds to match function comments
ced2ca7 
Function comments specify that n go routines are launched, but code
launches n+1. To match comments, launch n go routines instead of n+1.

Fixes golang/go#46223

Change-Id: I4e2bf6f521a52af351d6b6a33311988c082d8bec
GitHub-Last-Rev: a32ca355f59f9a2c11638e308caa4d7dee175544
GitHub-Pull-Request: golang/website#52
Reviewed-on: https://go-review.googlesource.com/c/website/+/320032
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

_content/doc/play: fix loop bounds to match function comments krishna-birla/website
3 participants
@dmitshur @gopherbot @krishna-birla