Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: make go mod download with no arguments leave go.sum alone [1.16 backport] #46214

Closed
gopherbot opened this issue May 17, 2021 · 5 comments
Closed

cmd/go: make go mod download with no arguments leave go.sum alone [1.16 backport] #46214

gopherbot opened this issue May 17, 2021 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go release-blocker
Milestone
Go1.16.5

Comments

@gopherbot
Copy link

@jayconrod requested issue #45332 to be considered for backport to the next 1.16 minor release.

@gopherbot Please backport to 1.16. We plan to revert to the 1.15 behavior.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 17, 2021
@gopherbot gopherbot mentioned this issue May 17, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.5 milestone May 17, 2021
@dmitshur dmitshur added the GoCommand cmd/go label May 17, 2021
@bcmills
Copy link
Contributor

bcmills commented May 19, 2021

We should make sure this lands sooner rather than later, so that folks who run later in the upgrade cycle don't experience as much churn adapting to 1.16.

@gopherbot
Copy link
Author

Change https://golang.org/cl/321892 mentions this issue: [release-branch.go1.16] cmd/go: in 'go mod download' without args, don't save module zip sums

@mknyszek mknyszek added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels May 24, 2021
@mknyszek
Copy link
Contributor

@bcmills This looks OK to me as a backport, since it's fixing behavior that (IIUC) users can't easily work around (or if they can, it's a significant burden to have to make users use a different method for Go 1.15 and earlier vs. Go 1.16 and later), and that has a negative impact on the UX of the modules. The change in behavior was introduced in Go 1.16. Does that sound about right?

@bcmills
Copy link
Contributor

bcmills commented May 24, 2021

Yep, that sounds accurate.

gopherbot pushed a commit that referenced this issue Jun 2, 2021
@cagedmantis
[release-branch.go1.16] cmd/go: in 'go mod download' without args, do…
dbf69b7 
…n't save module zip sums

'go mod download' without arguments is frequently used to populate the
module cache. It tends to fetch a lot of extra files (for modules in
the build list that aren't needed to build packages in the main
module). It's annoying when sums are written for these extra files.

'go mod download mod@version' will still write sums for specific
modules in the build list. 'go mod download all' still has the
previous behavior.

For now, all invocations of 'go mod download' still update go.mod and
go.sum with changes needed to load the build list (1.15 behavior).

Fixes #46214

Change-Id: I9e17d18a7466ac7271a0e1a2b663f6b3cb168c97
Reviewed-on: https://go-review.googlesource.com/c/go/+/318629
Trust: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit 4fb10b2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/321892
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link
Author

Closed by merging dbf69b7 to release-branch.go1.16.

@bayandin bayandin mentioned this issue Jun 7, 2021
Closed
@thbkrkr thbkrkr mentioned this issue Jun 7, 2021
Merged
1 task
@michel-laterman michel-laterman mentioned this issue Jun 10, 2021
Closed
4 tasks
@golang golang locked and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go release-blocker
Projects
None yet
Milestone
Go1.16.5
Development

No branches or pull requests
4 participants
@mknyszek @dmitshur @bcmills @gopherbot