Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/maintner: client Corpus is unhelpfully verbose by default #46180

Closed
dmitshur opened this issue May 14, 2021 · 4 comments
Closed

x/build/maintner: client Corpus is unhelpfully verbose by default #46180

dmitshur opened this issue May 14, 2021 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

What did you do?

Use a client *maintner.Corpus via the godata package.
See example code that reproduces this issue.

What did you expect to see?

Stdout filled with a reasonable amount of useful information.

What did you see instead?

Repeated mentions of "Unknown JSON in log":

2021/05/14 16:28:43 Loading data from log *maintner.netMutSource ...
2021/05/14 16:28:44 Downloading 1461526 bytes of https://maintner.golang.org/logs/91 ...
2021/05/14 16:28:44 wrote /Users/dmitshur/Library/Caches/golang-maintner/0091.growing.mutlog
2021/05/14 16:28:58 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:28:58 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:28:58 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:28:58 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:28:58 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:28:58 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"too heated"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"off-topic"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"too heated"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:28:59 Unknown JSON in log: {"lock_reason":"too heated"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"off-topic"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"off-topic"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"off-topic"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"off-topic"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"too heated"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"too heated"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:00 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"off-topic"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"off-topic"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"off-topic"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:01 Unknown JSON in log: {"lock_reason":"spam"}
2021/05/14 16:29:02 Unknown JSON in log: {"lock_reason":"resolved"}
2021/05/14 16:29:02 Unknown JSON in log: {"lock_reason":"off-topic"}
2021/05/14 16:29:02 Unknown JSON in log: {"lock_reason":"off-topic"}
2021/05/14 16:29:03 Reloaded data from log *maintner.netMutSource.

CC @golang/release, @ianthehat.
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label May 14, 2021
@dmitshur dmitshur added this to the Unreleased milestone May 14, 2021
@dmitshur dmitshur self-assigned this May 14, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 14, 2021
@gopherbot
Copy link

Change https://golang.org/cl/320289 mentions this issue: maintner: discard lock_reason in GitHub issue events

@gopherbot
Copy link

Change https://golang.org/cl/320290 mentions this issue: maintner: log about loading unknown JSON only in verbose mode

@Hrtkk
Copy link

Hrtkk commented May 15, 2021 •
edited

Hi @dmitshur, I would like to work on this issue. If it is available. As I can see, there is already a fix https://golang.org/cl/320290.

@dmitshur
Copy link
Contributor Author

@Hrtkk Thanks for offering. As you noticed, there are already 2 CLs out that will fix this issue. You're welcome to help with reviewing them. Thanks!

gopherbot pushed a commit to golang/build that referenced this issue May 17, 2021
@dmitshur
maintner: discard lock_reason in GitHub issue events
39f255e 
"lock_reason" is a field that was added to GitHub API v3 after maintner
was created. It's present in GitHub issue "locked" events and indicates
the reason the issue was locked, such as "off-topic", "too heated",
"resolved", etc.

Since maintner didn't have explicit handling for it, it got the default
treatment of being saved in OtherJSON just in case.

It's a non-goal for maintner to track all available data, only what is
deemed to be worth including. This field hasn't been used all this time
and seems fine to exclude until something changes.

Also fix a bug where OtherJSON wasn't even set in GitHubIssueEvent,
and improve various internal comments and log messages.

For golang/go#46180.

Change-Id: I9ebb3bf4183f78e413dfb032c94cb736a8b07e02
Reviewed-on: https://go-review.googlesource.com/c/build/+/320289
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@golang golang locked and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @Hrtkk