Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: investigate if we can get rid of internal gcCompatibilityMode flag #46174

Closed
griesemer opened this issue May 14, 2021 · 2 comments
Closed

go/types, types2: investigate if we can get rid of internal gcCompatibilityMode flag #46174

griesemer opened this issue May 14, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.18

Comments

@griesemer
Copy link
Contributor

See declaration and comment in typestring.go.
@griesemer griesemer added this to the Go1.18 milestone May 14, 2021
@griesemer griesemer self-assigned this May 14, 2021
@griesemer griesemer added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 14, 2021
@gopherbot
Copy link

Change https://golang.org/cl/339831 mentions this issue: [dev.typeparams] cmd/compile/internal/types2: remove unused gcCompatibilityMode flag (cleanup)

gopherbot pushed a commit that referenced this issue Aug 5, 2021
@griesemer
[dev.typeparams] cmd/compile/internal/types2: remove unused gcCompati…
f14908d 
…bilityMode flag (cleanup)

This flag is not needed by types2 (and possibly can also be removed
from go/types). Removed some unnecessary comments along the way.

Updates #46174.

Change-Id: I1a7a99f724205a084d1c9850bce6f6f5d33f83ca
Reviewed-on: https://go-review.googlesource.com/c/go/+/339831
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
@griesemer
Copy link
Contributor Author

This was fixed for types2 with the above CL, and for go/types with CL 342429.

@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@griesemer @gopherbot @findleyr