Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/maintner/maintnerd/maintapi: test x/tools CLs on gopls-release-branch.* branches also with past 2 releases #46156

Closed
dmitshur opened this issue May 13, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented May 13, 2021

In golang.org/x repo, TryBots testing CLs on branches other than the default "master" branch are only tested with Go tip, not with the past 2 releases (e.g., 1.16 and 1.15).

The gopls-release-branch.* branches in x/tools are used for issuing gopls releases, which are expected to work on currently supported Go releases, so these branches should be included in the wider testing.

(This doesn't apply more generally, e.g., custom branches like "dev.link" or "dev.go2go" may not work with non-tip versions of Go. So start by opting-in for branches that are known to support past Go versions.)

CC @golang/release, @stamblerre, @findleyr.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels May 13, 2021
@dmitshur dmitshur added this to the Unreleased milestone May 13, 2021
@dmitshur dmitshur self-assigned this May 13, 2021
@gopherbot
Copy link

Change https://golang.org/cl/319792 mentions this issue: maintner/maintnerd/maintapi: test x/tools gopls release branches with past Go

@golang golang locked and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants