Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/ed25519: TestAllocations fails with BoringCrypto or without optimizations #46134

Closed
FiloSottile opened this issue May 12, 2021 · 3 comments
Closed

crypto/ed25519: TestAllocations fails with BoringCrypto or without optimizations #46134

FiloSottile opened this issue May 12, 2021 · 3 comments
Assignees
@FiloSottile
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.20

Comments

@FiloSottile
Copy link
Contributor 

--- FAIL: TestAllocations (0.02s)
    ed25519_test.go:202: expected zero allocations, got 3e+01

Testing performance profiles is brittle: it currently fails on the noopt builder, and on the dev.boringcrypto branch. Even if we skipped it on both, it would fail on go test all if run without optimizations, like Delve does.

We can make it run only on a specific builder, but I am worried that will eventually drift out of sync with builder naming and end up never running. Better than nothing, I guess.
@FiloSottile FiloSottile added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 12, 2021
@FiloSottile FiloSottile added this to the Go1.17 milestone May 12, 2021
@FiloSottile FiloSottile self-assigned this May 12, 2021
@mknyszek mknyszek modified the milestones: Go1.17, Go1.18 Aug 18, 2021
@odeke-em
Copy link
Member

@FiloSottile thank you for filing this issue. We haven't done anything related for this cycle Go1.18, hence I am punting the issue to Go1.19.

@odeke-em odeke-em modified the milestones: Go1.18, Go1.19 Dec 20, 2021
@ianlancetaylor
Copy link
Contributor

CC @golang/security

Looks like this didn't make 1.19. Moving to backlog. Please recategorize as appropriate.

@ianlancetaylor ianlancetaylor modified the milestones: Go1.19, Backlog Jun 24, 2022
@FiloSottile
Copy link
Contributor Author

Fixed by https://go.dev/cl/422038.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 12, 2023
@dmitshur dmitshur modified the milestones: Backlog, Go1.20 Jan 12, 2023
@golang golang locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@FiloSottile FiloSottile

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Release Status & Release Blockers
Status: Done
Milestone
Go1.20
Development

No branches or pull requests
6 participants
@FiloSottile @mknyszek @dmitshur @ianlancetaylor @odeke-em @gopherbot