Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/releasebot: add an upper limit to the total log posted to GitHub #46130

Closed
cagedmantis opened this issue May 12, 2021 · 3 comments
Closed
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@cagedmantis
Copy link
Contributor

During a release, releasebot will post the release log as GitHub comments. In very rare occasions the release log will grow to an extremely long length which will mostly contain useless information. As originally suggested in CL 318070, we should agree upon a limit on how much of the log we post to GitHub.

@golang/release

@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels May 12, 2021
@cagedmantis cagedmantis added this to the Backlog milestone May 12, 2021
@dmitshur
Copy link
Contributor

I think it's hard to determine what an optimal value for this is, given how infrequently it may happen. I wanted to suggest 2 MB to match our current limit in x/build logs, but imagining releasebot posting 32 full-length comments (2 MB / 64 KB = 32) in an issue seems a bit too much (these will also contribute to making maintner dataset larger). Perhaps 4? Anything is better than unbounded IMO, and the human release coordinator can always add more context if needed.

Sorry about the unfortunate timing on the review comment and thanks for following up!

@dmitshur
Copy link
Contributor

Issue #47148 is a data point involving fairly verbose output, spanning 20 comments. Perhaps it can help make a decision here.

As a straw proposal, how about if len(bodyParts) <= 4, post them all, otherwise post the first 3 and the last one, since there may be more interesting stuff on the last page.
(If there's something exceptionally interesting in the middle, the release coordinator can access it from the terminal and share as needed.)

@dmitshur
Copy link
Contributor

dmitshur commented Aug 3, 2022

releasebot has been superseded by relui, and relui doesn't post to GitHub issues, so this issue no longer applies. Closing.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2022
@dmitshur dmitshur added this to Done in Go Release Team Aug 3, 2022
@golang golang locked and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
Archived in project
Development

No branches or pull requests

3 participants