Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: internal error when externally linking very large binaries [1.16 backport] #46128

Closed
gopherbot opened this issue May 12, 2021 · 3 comments
Closed

cmd/link: internal error when externally linking very large binaries [1.16 backport] #46128

gopherbot opened this issue May 12, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.16.5

Comments

@gopherbot
Copy link

@cherrymui requested issue #46126 to be considered for backport to the next 1.16 minor release.

@gopherbot please backport this. This is a build failure without easy workaround. Thanks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 12, 2021
@gopherbot gopherbot mentioned this issue May 12, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.5 milestone May 12, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/319369 mentions this issue: [release-branch.go1.16] cmd/link: don't cast end address to int32

@dmitshur
Copy link
Contributor

Approving per discussion in a release meeting. This backport applies to both 1.16 (this issue) and 1.15 (#46127).

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels May 21, 2021
@dmitshur dmitshur mentioned this issue May 21, 2021
Closed
@gopherbot
Copy link
Author

Closed by merging 305fa95 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue May 21, 2021
@cherrymui @dmitshur
[release-branch.go1.16] cmd/link: don't cast end address to int32
305fa95 
When linking a very large binary, the section address may not fit
in int32. Don't truncate it.

Fixes #46128.
Updates #46126.

Change-Id: Ibcc8d74bf5662611949e547ce44ca8b973de383f
Reviewed-on: https://go-review.googlesource.com/c/go/+/319289
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit af0f8c1)
Reviewed-on: https://go-review.googlesource.com/c/go/+/319369
@golang golang locked and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.16.5
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot