Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: stop writing pkg.test executable in directory when profiling? #46086

Open
josharian opened this issue May 10, 2021 · 0 comments
Open

cmd/go: stop writing pkg.test executable in directory when profiling? #46086

josharian opened this issue May 10, 2021 · 0 comments
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Unplanned

Comments

@josharian
Copy link
Contributor 

$ go test -bench=. -cpuprofile=cpu.pprof pkg

results in cmd/go writing pkg.test to the current directory. The original reason was so that pkg.test would be handy when running go tool pprof. But go tool pprof no longer requires access to the original executable, because the requisite information is in the profile itself.

Maybe we should stop writing it.
@josharian josharian changed the title cmd/go: stop write pkg.test executable in directory when profiling? cmd/go: stop writing pkg.test executable in directory when profiling? May 10, 2021
@ALTree ALTree added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 10, 2021
@seankhliao seankhliao added this to the Unplanned milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@josharian @ALTree @seankhliao