New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys/unix: add consts, structs and ioctl calls from <mtd/mtd-user.h>
#46063
Comments
Change https://golang.org/cl/318211 mentions this issue: |
According to @robpike in #14873:
If necessary I will back off the |
For better or for worse, I think that golang.org/x/sys/unix has clearly gone in a different direction since Rob's comment from five years ago. |
Oh, worse. Yes, worse. |
I've backed out the ioctl wrappers in I'll be happy to maintain another package using these structs and constants--easier and better to not further pollute x/sys |
This doesn't need to be a proposal. It's fine to add constants and types from system header files to x/sys/unix without writing a separate proposal for each set. |
<mtd/mtd-user.h>
<mtd/mtd-user.h>
What did you expect to see?
It would be convenient to have MTD user space constants, utils and ioctl operations in the package.
An example use case is in Facebook's OpenBMC repo here.
The proposed addition entails:
#include <mtd/mtd-user.h>
inunix/mkerrors.sh
with the sufficient regex changes#include <mtd/mtd-user.h>
inunix/linux/types.go
with the necessary bindings (C.struct_XXX
for structs, constants for enum)ioctl
functions inunix/ioctl.go
for unique types.The text was updated successfully, but these errors were encountered: